Take all incomplete results into account in overview statistics #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2564 +/- ##
==========================================
+ Coverage 91.44% 91.45% +<.01%
==========================================
Files 181 181
Lines 11180 11182 +2
==========================================
+ Hits 10224 10226 +2
Misses 956 956
Continue to review full report at Codecov.
|
okurz
reviewed
Dec 2, 2019
Martchus
force-pushed
the
fix-counting-incompletes
branch
from
bb514a4
to
b60b11e
Compare
Martchus
force-pushed
the
fix-counting-incompletes
branch
from
b60b11e
to
2ce3164
Compare
okurz
reviewed
Dec 3, 2019
| sub generalize_result { | ||
| my ($concrete_result) = @_; | ||
| return $GENERALIZED_RESULTS{$concrete_result} // NONE; | ||
| } |
There was a problem hiding this comment.
I see. This looks like a similar approach I needed to take in https://github.com/os-autoinst/openQA/pull/2489/files#diff-85ae48e70a5c110c9e439c3a5ea28d5fR233-R246 . So it looks like first we had a manageable list of states+results, then we added more, now we have too many and we need to map them to less. I guess eventually we should look into the "states" and "results" again.
kraih
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://progress.opensuse.org/issues/60458